Add Typing/MethodParameterTypeRestriction
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
requested changes
Dec 28, 2024
Sija
requested changes
Dec 28, 2024
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
|
I want to add more specs to this for splat / double splat |
|
Is there anything remaining for this PR to be merged? |
Sija
requested changes
Jan 9, 2025
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sija
reviewed
Jan 9, 2025
nobodywasishere
changed the title
Typing/MethodParamTypeRestrictionTyping/MethodParameterTypeRestriction
veelenga
reviewed
Jan 10, 2025
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
Co-authored-by: Vitalii Elenhaupt <[email protected]>
Sija
requested changes
Jan 12, 2025
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
Sija
requested changes
Jan 12, 2025
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sija
requested changes
Jan 12, 2025
Sija
requested changes
Jan 12, 2025
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
spec/ameba/rule/typing/method_parameter_type_restriction_spec.cr
Outdated
Show resolved
Hide resolved
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sija
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.